Skip to content

VR apiserver retrieves endpoint slices by a get call #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

VR apiserver retrieves endpoint slices by a get call #3696

wants to merge 1 commit into from

Conversation

@gman0
Copy link
Contributor

@gman0 gman0 commented Nov 3, 2025

Summary

Endpoint slices are now retrieved by GET-ting them from cache. The slice must be co-located with the APIExport that exports the VR, and so the export's shard and cluster name is used.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #3695

Release Notes

NONE

@gman0
VR apiserver retrieves endpoint slices by a get call
ddd333e 
Endpoint slices are now retrieved by GET-ting them from cache.
The slice must be co-located with the APIExport that exports
the VR, and so the export's shard and cluster name is used.

On-behalf-of: @SAP [email protected]
Signed-off-by: Robert Vasek <[email protected]>
@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2025
@gman0
Copy link
Contributor Author

gman0 commented Nov 3, 2025

/retest

@gman0
Copy link
Contributor Author

gman0 commented Nov 5, 2025

/retest

Maybe this resets the tide job?

mjudeikis
mjudeikis approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Nov 5, 2025

LGTM label has been added.

Git tree hash: 38c3fccc85bd0f7b895ccc32b61fdb2ca4580c16

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@gman0
Copy link
Contributor Author

gman0 commented Nov 5, 2025

/retest

A bunch of tests failed with "Pod scheduling timeout."

@gman0
Copy link
Contributor Author

gman0 commented Nov 6, 2025

/retest

@gman0
Copy link
Contributor Author

gman0 commented Nov 6, 2025 •
edited
Loading

There was a panic: cache *v1alpha1.LogicalCluster modified in test/e2e/apibinding TestAPIBindingCRDs. Unrelated, but something we should have a look later: #3700

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Nov 6, 2025 •
edited
Loading

@gman0: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-e2e-sharded ddd333e link true /test pull-kcp-test-e2e-sharded
pull-kcp-test-e2e-shared ddd333e link unknown /test pull-kcp-test-e2e-shared

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: virtual resources apiserver resolves to wrong endpoint slice

3 participants

@gman0 @kcp-ci-bot @mjudeikis